WebRTC: Support WHEP for play. v5.0.182 v6.0.80 #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen-guanghua
approved these changes
Feb 6, 2023
xiaozhihong
approved these changes
Feb 8, 2023
|
Wow great work! |
|
Seems WHEP is not updated, so we should hold on this PR, and shouldn't merge it util WHEP has some updates. |
winlinvip
force-pushed
the
develop
branch
3 times, most recently
from
c056094 to
2ac9eb8
Compare
|
WHEP updated on 2023-03-29, maybe it can be merged.
|
|
When ingesting a WHIP stream in Stereo it is downmixed to Mono by WHEP Player. on WHIP side: on WHEP side: No chance to set the custom parameters stereo=1 or sprop-stereo=1 on client side. |
winlinvip
changed the title
winlinvip
added a commit
that referenced
this pull request
Sep 21, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/ RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/ Please note that SRS 5.0 already had WHIP support. I didn't write a document about WHIP, because WHIP is not a RFC right now, but there are clues in [srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS WHIP url for publisher: `http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream` This PR is for WHEP, the url for player is `http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream` PS: There is a great PR for OBS to have WHIP support, see obsproject/obs-studio#7926 and #3581 PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1 See #3170 --------- Co-authored-by: Haibo Chen <495810242@qq.com> Co-authored-by: john <hondaxiao@tencent.com> Co-authored-by: ChenGH <chengh_math@126.com>
duiniuluantanqin
added a commit
to duiniuluantanqin/srs
that referenced
this pull request
Oct 11, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/ RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/ Please note that SRS 5.0 already had WHIP support. I didn't write a document about WHIP, because WHIP is not a RFC right now, but there are clues in [srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS WHIP url for publisher: `http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream` This PR is for WHEP, the url for player is `http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream` PS: There is a great PR for OBS to have WHIP support, see obsproject/obs-studio#7926 and ossrs#3581 PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1 See ossrs#3170 --------- Co-authored-by: Haibo Chen <495810242@qq.com> Co-authored-by: john <hondaxiao@tencent.com> Co-authored-by: ChenGH <chengh_math@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/
RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/
Please note that SRS 5.0 already had WHIP support. I didn't write a document about WHIP, because WHIP is not a RFC right now, but there are clues in srs-unity. SRS WHIP url for publisher:
http://localhost:1985/rtc/v1/whip/?app=live&stream=livestreamThis PR is for WHEP, the url for player is
http://localhost:1985/rtc/v1/whep/?app=live&stream=livestreamPS: There is a great PR for OBS to have WHIP support, see obsproject/obs-studio#7926 and #3581
PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1
See #3170
Co-authored-by: Haibo Chen 495810242@qq.com
Co-authored-by: john hondaxiao@tencent.com
Co-authored-by: ChenGH chengh_math@126.com