-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support include directive for config file #2878
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2878 +/- ##
===========================================
+ Coverage 60.09% 60.24% +0.15%
===========================================
Files 121 121
Lines 51310 51522 +212
===========================================
+ Hits 30836 31041 +205
- Misses 20474 20481 +7 | Impacted Files | Coverage Δ | |' Translated to English while maintaining the markdown structure: '| Impacted Files | Coverage Δ | | Translated to English while maintaining the markdown structure: | trunk/src/app/srs_app_config.hpp | Translated to English while maintaining the markdown structure: | trunk/src/core/srs_core_autofree.hpp | Continue to review full report at Codecov.
Translated to English while maintaining the markdown structure: |
|
Thank you, 👍 This feature has been mentioned before, to support the nginx include directive, but no one has implemented it until today: #1399 Also, please make sure to add Utest coverage to verify that specific configurations are working correctly. We have previously added Utest testing to our configuration file parsing.
|
Okay, I will try my best to improve the code. Thank you.
|
In addition, please branch from develop, submit to develop. Currently, version 4.0 has been released and no new features will be added, only bug fixes.
|
Okay
|
You can continue using this PR. If you don't know how to operate it, you can contact me on WeChat.
|
|
987f3b4
to
d3fa81a
Compare
Thank you very much for making so many improvements, hahaha. I think this PR has been done very well, thank you very much. However, there is still a slight gap from what I want. I will make some further improvements based on your work. 😄
|
This comment was marked as spam.
This comment was marked as spam.
Refine the mock for including in config
Summary
Support include import configuration
Details
Add include to import multiple configuration files, similar to nginx.