Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsrtp2: fix compilation with GCC 10 #2397

Closed
wants to merge 1 commit into from

Conversation

HungMingWu
Copy link
Contributor

Please refer the issue on the link openwrt/telephony#546

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #2397 (8c76fbd) into 4.0release (d526672) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           4.0release    #2397      +/-   ##
==============================================
- Coverage       38.73%   38.72%   -0.01%     
==============================================
  Files             109      109              
  Lines           39658    39658              
==============================================
- Hits            15360    15359       -1     
- Misses          24298    24299       +1     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/protocol/srs_service_utility.cpp | 72.43% <0.00%> (-0.55%) | ⬇️ |


Continue to review full report at Codecov.

Legend - Click here to learn more
Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update d526672...8c76fbd. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Jun 3, 2021

Thank you for your contribution. 👍

It seems like this is an issue with the SRTP code. Can we consider submitting a PR to SRTP as well?

TRANS_BY_GPT3

@HungMingWu
Copy link
Contributor Author

HungMingWu commented Jun 3, 2021

I don't know where the repo for srtp is.. libsrtp doesn't seem like it.

TRANS_BY_GPT3

@winlinvip winlinvip force-pushed the 4.0release branch 9 times, most recently from bf2c3a1 to 5e87627 Compare August 16, 2021 01:15
@winlinvip winlinvip self-requested a review August 27, 2021 00:06
@winlinvip winlinvip self-assigned this Aug 27, 2021
@winlinvip winlinvip added this to the SRS 4.0 release milestone Aug 27, 2021
@winlinvip
Copy link
Member

Merged as cc99226

👍 Thanks a lot @HungMingWu

@winlinvip winlinvip closed this Oct 30, 2021
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants