Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB28181: fix parse rtp-tcp failed #2378

Merged
merged 2 commits into from
May 28, 2021

Conversation

cfw11
Copy link
Contributor

@cfw11 cfw11 commented May 27, 2021

Fix RTP parsing error.
Remove redundant code.
fix #2217


TRANS_BY_GPT3

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #2378 (f75e538) into develop (bbd7ee0) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2378      +/-   ##
===========================================
+ Coverage    38.44%   38.61%   +0.16%     
===========================================
  Files          109      109              
  Lines        39993    39825     -168     
===========================================
+ Hits         15376    15377       +1     
+ Misses       24617    24448     -169     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_gb28181.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_gb28181.hpp | 0.00% <ø> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_gb28181.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_gb28181.hpp | 0.00% <ø> (ø) | |
| trunk/src/protocol/srs_service_utility.cpp | 72.97% <0.00%> (+0.54%) | ⬆️ |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update bbd7ee0...f75e538. Read the comment docs.

TRANS_BY_GPT3

@winlinvip winlinvip changed the title fix parse rtp-tcp failed GB28181: fix parse rtp-tcp failed May 27, 2021
@xialixin
Copy link
Contributor

xialixin commented May 27, 2021

Thank you for submitting the PR. I have made some optimizations to the SDP TCP description in the srs_gb28281_stack.cpp file based on your PR. I added the line 'a=setup:passive'.
"a=connection:new"
, At the same time, the default for push.gb28181.conf is UDP, so I created push.gb28181.tcp.conf to support TCP.

#2382

TRANS_BY_GPT3

@cfw11
Copy link
Contributor Author

cfw11 commented May 28, 2021

Received

TRANS_BY_GPT3

@winlinvip winlinvip merged commit 4d6f00e into ossrs:develop May 28, 2021
winlinvip pushed a commit that referenced this pull request May 28, 2021
* fix parse rtp-tcp failed

* fix parse rtp-tcp failed

Co-authored-by: cfw <fangwei.cheng@transwarp.io>
@winlinvip
Copy link
Member

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GB28181: TCP streaming failed and the stream keeps pushing
4 participants