-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS: Fix the issue of increasing video timestamp interleaving, causing HLS recording failure, and the problem of frame loss in the queue. #1872
base: 3.0release
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0release #1872 +/- ##
==============================================
- Coverage 52.89% 52.84% -0.05%
==============================================
Files 82 82
Lines 26629 26653 +24
==============================================
Hits 14085 14085
- Misses 12544 12568 +24 | Impacted Files | Coverage Δ | |' '| Impacted Files | Coverage Δ | |
|
Codecov Report
@@ Coverage Diff @@
## 3.0release #1872 +/- ##
==============================================
- Coverage 53.19% 52.84% -0.35%
==============================================
Files 82 82
Lines 26313 26653 +340
==============================================
+ Hits 13997 14085 +88
- Misses 12316 12568 +252 | Impacted Files | Coverage Δ | |' '| Impacted Files | Coverage Δ | | Continue to review full report at Codecov.
|
1f7a7e8
to
9ee8db2
Compare
1ca9308
to
8d44b98
Compare
First of all, thank you very much for submitting the PR 👍 HLS has never enabled timestamp correction algorithm because TS does not have a clear requirement for timestamp monotonicity. If corrected, it may cause other issues, but not correcting it may also lead to some problems. So, this PR still needs some time to consider whether the current problem requires timestamp correction and whether there are other solutions available.
|
The problem of alternating increasing timestamps
The issue at #1871 will cause the following problems:
TRANS_BY_GPT3