Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS: Fix the issue of increasing video timestamp interleaving, causing HLS recording failure, and the problem of frame loss in the queue. #1872

Open
wants to merge 2 commits into
base: 3.0release
Choose a base branch
from

Conversation

NodeBoy2
Copy link

@NodeBoy2 NodeBoy2 commented Jul 23, 2020

The problem of alternating increasing timestamps
The issue at #1871 will cause the following problems:

  1. Frequent triggering and direct deletion of HLS recording files.
  2. Setting time_jitter off results in missing video (or audio) during playback.

TRANS_BY_GPT3

@NodeBoy2 NodeBoy2 changed the title fix https://github.com/ossrs/srs/issues/1871: 修复视频时间戳交错增加,导致hls录制失败,以及queue丢帧的问题 修复视频时间戳交错增加,导致hls录制失败,以及queue丢帧的问题 Jul 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #1872 into 3.0release will decrease coverage by 0.04%.
The diff coverage is 5.12%.

Impacted file tree graph

@@              Coverage Diff               @@
##           3.0release    #1872      +/-   ##
==============================================
- Coverage       52.89%   52.84%   -0.05%     
==============================================
  Files              82       82              
  Lines           26629    26653      +24     
==============================================
  Hits            14085    14085              
- Misses          12544    12568      +24     

| Impacted Files | Coverage Δ | |'

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_hls.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_source.cpp | 0.66% <0.00%> (-0.01%) | ⬇️ |
| trunk/src/app/srs_app_fragment.cpp | 12.31% <13.33%> (+0.12%) | ⬆️ |
| trunk/src/protocol/srs_rtmp_handshake.cpp | 84.05% <0.00%> (-0.36%) | ⬇️ |
| trunk/src/service/srs_service_utility.cpp | 77.84% <0.00%> (ø) | |

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f1aee...8d75a18. Read the comment docs.

TRANS_BY_GPT3

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #1872 into 3.0release will decrease coverage by 0.34%.
The diff coverage is 14.17%.

Impacted file tree graph

@@              Coverage Diff               @@
##           3.0release    #1872      +/-   ##
==============================================
- Coverage       53.19%   52.84%   -0.35%     
==============================================
  Files              82       82              
  Lines           26313    26653     +340     
==============================================
+ Hits            13997    14085      +88     
- Misses          12316    12568     +252     

| Impacted Files | Coverage Δ | |'

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_async_call.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_caster_flv.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_config.hpp | 0.00% <ø> (ø) | |
| trunk/src/app/srs_app_dvr.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_encoder.cpp | 0.62% <0.00%> (-0.01%) | ⬇️ |
| trunk/src/app/srs_app_ffmpeg.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_forward.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_hls.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_conn.cpp | 0.00% <0.00%> (ø) | |
| ... and 26 more | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1067d...8d75a18. Read the comment docs.

TRANS_BY_GPT3

@winlinvip winlinvip force-pushed the 3.0release branch 25 times, most recently from 1f7a7e8 to 9ee8db2 Compare August 15, 2021 08:32
@winlinvip winlinvip force-pushed the 3.0release branch 6 times, most recently from 1ca9308 to 8d44b98 Compare August 15, 2021 09:22
@winlinvip winlinvip self-requested a review August 27, 2021 00:21
@winlinvip winlinvip self-assigned this Aug 27, 2021
@winlinvip winlinvip added this to the SRS 4.0 release milestone Aug 27, 2021
@winlinvip winlinvip changed the title 修复视频时间戳交错增加,导致hls录制失败,以及queue丢帧的问题 HLS: 修复视频时间戳交错增加,导致hls录制失败,以及queue丢帧的问题 Oct 22, 2021
@winlinvip
Copy link
Member

winlinvip commented Oct 22, 2021

First of all, thank you very much for submitting the PR 👍
Make sure to maintain the markdown structure.

HLS has never enabled timestamp correction algorithm because TS does not have a clear requirement for timestamp monotonicity. If corrected, it may cause other issues, but not correcting it may also lead to some problems.
Make sure to maintain the markdown structure.

So, this PR still needs some time to consider whether the current problem requires timestamp correction and whether there are other solutions available.
Make sure to maintain the markdown structure.

TRANS_BY_GPT3

@winlinvip winlinvip added the Enhancement Improvement or enhancement. label Oct 26, 2021
@winlinvip winlinvip removed this from the 4.0 milestone Dec 9, 2022
@winlinvip winlinvip changed the title HLS: 修复视频时间戳交错增加,导致hls录制失败,以及queue丢帧的问题 HLS: Fix the issue of increasing video timestamp interleaving, causing HLS recording failure, and the problem of frame loss in the queue. Jul 29, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement or enhancement. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants