Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update init.d file #1039

Merged
merged 1 commit into from
Jan 4, 2018
Merged

update init.d file #1039

merged 1 commit into from
Jan 4, 2018

Conversation

RocFang
Copy link
Contributor

@RocFang RocFang commented Jan 4, 2018

Hi, @winlinvip

there are two points may need to be update:

  1. In function of start, since srs is already running and failed_msg is used, maybe it's not proper to return 0.
  2. this check will always success after ret=$?

thanks.

@winlinvip winlinvip changed the base branch from master to 2.0release January 4, 2018 05:44
@winlinvip
Copy link
Member

👍 I will merge to 2.0release/3.0release/develop.
I will merge to master when next version of 2.0release is released.

@winlinvip winlinvip merged commit d22d7af into ossrs:2.0release Jan 4, 2018
winlinvip added a commit that referenced this pull request Jan 4, 2018
@winlinvip
Merge #1039, fix bug of init.d script.
a6bc53c
@RocFang RocFang deleted the patch-1 branch January 4, 2018 06:10
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RocFang @winlinvip