Implement ICE consent freshness #44
Conversation
murillo128
force-pushed
the
consent-freshness
branch
from
cd0365f to
39b2fc7
Compare
Signed-off-by: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
murillo128
force-pushed
the
consent-freshness
branch
from
39b2fc7 to
826b6ac
Compare
libavformat/whip.c
Outdated
| @@ -143,6 +142,12 @@ | |||
| #define WHIP_RTCP_PT_START 192 | |||
| #define WHIP_RTCP_PT_END 223 | |||
|
|
|||
| /** | |||
| * Consent-freshness constants ����������������������������������������� | |||
libavformat/whip.c
Outdated
| /** | ||
| * Consent-freshness constants ����������������������������������������� | ||
| */ | ||
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ |
|
Hi Sergio, thank you for your PR. Could you please provide some background information for this PR in the description? The patch will be generated based on the title and description, and it will be sent via email to the FFmpeg community. Therefore, a detailed description is important for the maintainers to review this PR. |
libavformat/whip.c
Outdated
| /** | ||
| * Consent-freshness constants ����������������������������������������� | ||
| */ | ||
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ |
There was a problem hiding this comment.
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ | |
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms - RFC 7675 default */ |
|
WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side. The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests. |
|
I think all special chars are removed now |
winlinvip
force-pushed
the
workflows
branch
3 times, most recently
from
3294e09 to
4aa17ba
Compare
WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side.
The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests.