Feature: add ICE lite support and NACK support for WHIP #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLau1222
changed the title
winlinvip
reviewed
Jun 9, 2025
| /** | ||
| * Consent-freshness constants ����������������������������������������� | ||
| */ | ||
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ |
There was a problem hiding this comment.
@murillo128 we need your help
|
Each PR should be relevant to a single feature or bug fix. Please split it into multiple PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the whip code in FFmpeg master and #19 , it aims to improve this feature
Key Changes:
avformat/whip: Implement ICE lite support and consent freshness
avformat/whip: Implement nack+rtx support for video
Usage
You can follow the usage to test this patch.