Skip to content

Conversation

mkdolan
Copy link

@mkdolan mkdolan commented Oct 3, 2025

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@mkdolan mkdolan requested a review from a team as a code owner October 3, 2025 17:34
@mkdolan mkdolan requested review from raghavkaul and AdamKorcz and removed request for a team October 3, 2025 17:34
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 3, 2025
@mkdolan mkdolan temporarily deployed to integration-test October 3, 2025 17:34 — with GitHub Actions Inactive
@mkdolan mkdolan marked this pull request as draft October 3, 2025 17:35
@mkdolan mkdolan changed the title Added key Qwen, Meta-Llama, and OSS GPT repositories Add repositories: key Qwen, Meta-Llama, and OSS GPT repositories Oct 3, 2025
@mkdolan mkdolan marked this pull request as ready for review October 3, 2025 17:37
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.89%. Comparing base (353ed60) to head (f908453).
⚠️ Report is 252 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4811      +/-   ##
==========================================
+ Coverage   66.80%   67.89%   +1.09%     
==========================================
  Files         230      249      +19     
  Lines       16602    19124    +2522     
==========================================
+ Hits        11091    12985    +1894     
- Misses       4808     5277     +469     
- Partials      703      862     +159     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencerschrock
Copy link
Member

Hi Mike, we require DCO on all commits.

Please see this link for how to fix this
https://github.com/ossf/scorecard/pull/4811/checks?check_run_id=51908860210

Signed-off-by: Mike Dolan <mikedolan@gmail.com>
@mkdolan
Copy link
Author

mkdolan commented Oct 6, 2025

Hi Mike, we require DCO on all commits.

Please see this link for how to fix this https://github.com/ossf/scorecard/pull/4811/checks?check_run_id=51908860210

That's odd because in the commit itself on GitHub, it shows I have a signed-off-by statement. I have VS Code set up to -s sign all my commits.

Screenshot 2025-10-06 at 12 16 08 PM

@mkdolan mkdolan deployed to integration-test October 6, 2025 16:22 — with GitHub Actions Active
@spencerschrock
Copy link
Member

Looks good now thanks, but your original commit didn't have it: a1a1f67

I want to do a quick check on these repos to make sure none of them actually have the multi-gig models in them.

@mkdolan
Copy link
Author

mkdolan commented Oct 6, 2025

Looks good now thanks, but your original commit didn't have it: a1a1f67

Not sure what I did wrong on the first pass - thanks for checking it and sorry for any confusion.

I want to do a quick check on these repos to make sure none of them actually have the multi-gig models in them.

I believe all the larger weights and parameters files for these models are all stored on HuggingFace, not the GitHub repo. This should mostly be inference code, APIs, examples, etc. If I got any of that wrong and there is a large model file, I'd certainly understand the rationale to exclude the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants