Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix issue template ossf link #83

Merged
merged 7 commits into from
Jun 25, 2024
Merged

🐛 Fix issue template ossf link #83

merged 7 commits into from
Jun 25, 2024

Conversation

lelia
Copy link
Contributor

@lelia lelia commented Jun 20, 2024

Fixes the issue.ejs template to use the correct ossf/scorecard-monitor link as seen in report.ejs.

Refs: #75, #79.

@lelia
Fix issue template ossf link
1528dd5 
Signed-off-by: lelia <le1ia@me.com>
@lelia lelia mentioned this pull request Jun 20, 2024
Merged
@lelia
Rebuild js
9ec23a8 
Signed-off-by: lelia <le1ia@me.com>
@lelia
Copy link
Contributor Author

lelia commented Jun 20, 2024 •
edited
Loading

Hey @UlisesGascon — I couldn't find any dev setup instructions in the README or CONTRIBUTING guide for building the project — npm run build doesn't seem to have done the trick — so if you could point me in the right direction to get the source build working, that would be super appreciated 🙂

justaugustus
justaugustus requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you edit to "by OpenSSF Scorecard Monitor"?

@lelia
Address review feedback
1dffa32 
Signed-off-by: lelia <le1ia@me.com>
@UlisesGascon UlisesGascon mentioned this pull request Jun 21, 2024
Merged
@UlisesGascon
Copy link
Member

Thanks for working on this @lelia!

I just created a contributing guide in #85, based on that npm run test:update will fix the issue in the CI as the snapshots are outdated.

@lelia
Update outdated snapshots for tests
70e17e1 
Signed-off-by: lelia <le1ia@me.com>
@lelia
Copy link
Contributor Author

lelia commented Jun 21, 2024

Thanks for working on this @lelia!

I just created a contributing guide in #85, based on that npm run test:update will fix the issue in the CI as the snapshots are outdated.

Thanks for the tip @UlisesGascon! Looks like that did the trick 🙂

@lelia
Copy link
Contributor Author

lelia commented Jun 21, 2024

Can you edit to "by OpenSSF Scorecard Monitor"?

@justaugustus Done!

@lelia lelia mentioned this pull request Jun 21, 2024
Merged
@lelia lelia changed the title Fix issue template ossf link 🐛 Fix issue template ossf link Jun 21, 2024
UlisesGascon
UlisesGascon previously approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

justaugustus
justaugustus requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lelia — Can you rebase and fix the merge conflicts?

I've merged #84 to ensure that there was validation on the dist/ folder for future PRs (like this one :))

UlisesGascon and others added 2 commits June 25, 2024 18:48
@UlisesGascon @lelia
🌱 Add step to validate the dist folder content (ossf#84)
5675aee 
* ci: add step to validate the dist folder content

Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>

* chore: update dist folder

Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>

* chore: linting

Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>

---------

Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@lelia
Fix merge conflict, rebuild dist files
f6b9e23 
Signed-off-by: lelia <le1ia@me.com>
@lelia
Fix additional conflicts
0834d0c 
Signed-off-by: lelia <le1ia@me.com>
justaugustus
justaugustus approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lelia!

@justaugustus justaugustus merged commit c8380fe into ossf:main Jun 25, 2024
2 checks passed
@lelia lelia mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@UlisesGascon UlisesGascon UlisesGascon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lelia @UlisesGascon @justaugustus