fix result file path issues #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues at play that prevented the binary from reading the correct results file: 1. The paths were not joined with a separator. This led to file not found errors, as the file was saved in the wrong place with the wrong name. 2. The signing code tried to read the file from the current working directory instead of the GitHub workspace directory. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
justaugustus
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues at play that prevented the binary from reading the correct results file:
I was able to test this code after modifying the testing command in the
Dockerfileto use a differentGITHUB_WORKSPACEdirectory. The signing portion of the code will need to wait until the e2e test to confirm the fix.We should eventually improve the testing instructions, but at least the e2e test we have now caught this (via #1426 and #1427):
docker run -e GITHUB_REF=refs/heads/main \ -e GITHUB_EVENT_NAME=branch_protection_rule \ -e INPUT_RESULTS_FORMAT=json \ -e INPUT_RESULTS_FILE=results.json \ -e GITHUB_WORKSPACE="/home/runner/work/spencerschrock/actions-test" \ -e INPUT_POLICY_FILE="/policy.yml" \ -e INPUT_REPO_TOKEN=$GITHUB_AUTH_TOKEN \ -e GITHUB_REPOSITORY="spencerschrock/actions-test" \ -e GITHUB_EVENT_PATH="/event.json" \ -e GITHUB_API_URL="https://api.github.com" \ -e INPUT_PUBLISH_RESULTS="true" \ -v /tmp/docker:/home/runner/work/spencerschrock/actions-test \ spencerschrock/scorecard-action:latestFixes #1426
Fixes #1427
Fixes #1429