🌱 specify golangci-lint version in action
#1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't set it, the action uses the latest release. Version changes should be controlled, as new linter versions often lead to new findings which need to be dealt with. Signed-off-by: Spencer Schrock <sschrock@google.com>
deadline was deprecated in 2019 and support was removed in v1.57.0 of golangci-lint Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
a team,
justaugustus and
raghavkaul
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 4 4
Lines 296 296
=======================================
Hits 187 187
Misses 94 94
Partials 15 15 |
raghavkaul
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't set it, the action uses the latest release, which changes outside our control.
Version changes should be controlled, as new linter versions often lead to new findings which need to be dealt with.
Also use
timeoutinstead ofdeadlinein our configuration.deadlinewas deprecated in 2019 and support was removed in v1.57.0 of golangci-lint