Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Skip cosign confirmation prompt when publishing scorecard results. #1143

Merged

Conversation

spencerschrock
Copy link
Member

Fixes #1141 #1142

Cosign added a privacy confirmation prompt before uploading to the tlog, which causes scorecard action to fail as we dont run interactively.

This PR adds the equivalent of the following cosign CLI option:

  -y, --yes   skip confirmation prompts for non-destructive operations

Related: ossf/scorecard#2918

Signed-off-by: Spencer Schrock <sschrock@google.com>
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1143 (3873c1a) into main (3eabc86) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   63.96%   63.70%   -0.26%     
==========================================
  Files           4        4              
  Lines         247      248       +1     
==========================================
  Hits          158      158              
- Misses         74       75       +1     
  Partials       15       15              
Impacted Files Coverage Δ
signing/signing.go 36.36% <0.00%> (-0.38%) ⬇️

@spencerschrock spencerschrock merged commit 914ca3e into ossf:main May 11, 2023
@spencerschrock spencerschrock deleted the fix/cosign-privacy-confirmation branch May 11, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing e2e tests - scorecard-head on ossf-tests/scorecard-action
2 participants