Skip to content

Commit

Permalink
Move images using load/save instead of docker daemon. (#998)
Browse files Browse the repository at this point in the history
This change is necessary because the docker daemon API has a minimum of
1.24, but buildah and podman use a minimum version of 1.22.

Using the save + load bypasses API issues by using the standard approach
to saving and loading images.

Signed-off-by: Caleb Brown <calebbrown@google.com>
  • Loading branch information
calebbrown authored Jan 22, 2024
1 parent ae8550a commit b443fa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ push_prod_images: push_prod_sandboxes push_analysis_image push_scheduler_image
# pass '-nopull' to scripts/run_analysis.sh
#
sync_%_sandbox:
sudo buildah pull docker-daemon:${REGISTRY}/${IMAGE_NAME}:$(TAG)
docker save ${REGISTRY}/${IMAGE_NAME}:$(TAG) | sudo podman load

sync_dynamic_analysis_sandbox: IMAGE_NAME=dynamic-analysis
sync_dynamic_analysis_sandbox: build_dynamic_analysis_sandbox
Expand Down

0 comments on commit b443fa7

Please sign in to comment.