[REve] Update to RenderCore release from github, deploy it as builtin tarball. #41

osschar · 2022-12-20T07:14:01Z

This PR serves as expanded version of PR to root-project#11936 where the commits have been squashed into a single commit.

- Move some RenderCore specific classes and all shaders into RenderCore source tree.

- Implement all existing Three.js functionality with RenderCore.

- In RenderCore, further improve on existing functionality:
  - Textured points - arbitrary size and shape.
  - Mesh lines - arbitrary thickness.
  - Object and sub-object picking through color buffer with fragment depth detection.
  - Camera handling like in TEve, with ability to pick rotation center.

C++ / Server Changes

- REveManager: Make RenderCore the default rendering engine.

- Stream interpreter errors and show them in client log

- Add flag fIsRCore to REveManager.

- Make REvePointSet secondary-selectable.

- Add parameter for projection depth in REveDataCollection

JS / Client Changes

- Remove error MessageBox popup during client updates.

- EveManager.js: Check change bits in ImportSceneBinary when scene changes are streamed.

- EveScene.js: Optimize visibility changes.

- EveScene.js: pass eve_element instead of object3d in cases
  where it simplifies the code.

- EveScene.js, GlViewer classes: Cleamup highlite/selection management so it
  can be abstracted for RCore.

- Separate viewer-side selection processing for Three / RCore.

Tutorials / Demos Changes

- event_demo.C: secondary select points, jet title include pT.

- Tune marker sizes, colors, visual parameters.

…oaded. Prototype secondary selection.

- Use RC.ZSprite for REvePointSet rendering. - REvePointSet - export point-data in RGBA32F texture for RC. - REveRenderData - add static CalcTextureSize() to calculate texture width and height. - Add flag IsRCore to REveManager. - GlViewerRCore.js - always use RenderQueue rendering.

- Make REvePointSet secondary-selectable. - EveScene.js: pass eve_element instead of object3d in some cases that simplify the code. - RenderCore -- steps towards secondary selection

…tline. * event_demo.C: sec-select points, jet title include pT. * EveElementsRCore.js: implement control classes for selection. * EveScene.js, GlViewer classes: Cleamup highlite/selection management so it can be abstracted for RCore.

In GlViewerRCore, to workaround around single outline pass, merge indices from selection and highlight.

…; proto ZLine (multiple instanceData textures).

… control to set camera center

* RendeQuTor, GlViewerRCore - deep control of rendering passes, reuse intermediate 16F buffers. - outline selection and highlight properly. - pre-download picking, gbuffer, outline shaders. * Cleanup console logs.

… tracks

…s scenes

…odified in Firefox.

osschar and others added 30 commits December 12, 2022 14:53

Update to RenderCore release from github.

ec236b7

Getting render core colors, lights to reason.

7efa18e

Get rcore uint picking to work again, improve point rendering.

e3642cb

Trying out secondary select.

d807fd7

Re-call RenderCore::render from when some shaders have not yet been l…

67ba8c3

…oaded. Prototype secondary selection.

Pickable zsprite as points.

fbc374c

[REve] Initial steps for secondary selection with RCore.

2ac0cb9

- Make REvePointSet secondary-selectable. - EveScene.js: pass eve_element instead of object3d in some cases that simplify the code. - RenderCore -- steps towards secondary selection

[REve] Add some sprite textures for RenderCore.

80928a2

Add functions to create Calo3D and its controll object.

19c9aa6

add function to create Calo2D and its controll object calo2DControll

dc953ea

Import code for rendering REveBoxSet. Add box set control class

b0b01c1

[REve] Separate viewer-side selection processing for RCore.

cfc608c

[REve] Support outlining of specific instances.

499b1db

In GlViewerRCore, to workaround around single outline pass, merge indices from selection and highlight.

[REve] Get Calo objects, BoxSet and StraightLineSet to work with RCore.

984a46d

[REve] Use RCore dFdxy flat shading and new point-light model.

506266a

[REve] [RCore] Integration with new outline / blending / tone-mapping…

258bb44

…; proto ZLine (multiple instanceData textures).

[REve] [RCore] Use reduced 32x32 vieport around mouse event for picking.

3ebdf7f

[REve] Fix gl access in pick with depthdetection.

6f1b8cc

[REve] RCore renderer unbinds the FBO when doing RTT.

bd0e60e

Change algorithm for depth in pick function.

e99a129

Rewrite camera control to use ROOT GL camBase and camTrans logic. Add…

8d7ca91

… control to set camera center

[REve] Proper selection / highlight outlines, optimize buffer usage.

858c7d0

* RendeQuTor, GlViewerRCore - deep control of rendering passes, reuse intermediate 16F buffers. - outline selection and highlight properly. - pre-download picking, gbuffer, outline shaders. * Cleanup console logs.

Fix picking in projected polygon set. (from Matevz)

eb24df5

replace RC.Line with RC.Stripes in projected jets, line segments, and…

8c5c49e

… tracks

[REve] Proper setting of object matrices, comment/log cleanups.

45c1ebc

[REve] typo fix.

527f891

Add parameter for projection depth in the collection

67142a6

Add datGUI to set backgroundcolor

4e41fd0

osschar and others added 27 commits December 12, 2022 14:56

Code to render without tone mapping.

aeac9f7

Fix typo in the default argument

e3233fc

Fix resizing and event handling for high-dpi/retina.

4df5cbe

Scale markers and lines by device-pixel-ratio.

ab6436b

Use the same scaling factor in tracks and line segments

68e4a77

Correction in view navigation

f8d8c59

Unregister scene from receivers when viewer removes the scene from it…

1224c47

…s scenes

Implement clenup function for the case of view navigations/routing

1cacb1b

Save clear color in EveViewer attributes

5a2c19c

Add support boxset hex type

c2bb2e2

Fix line/track scaling with ssaa, pixelScale.

450a3e4

Correction in straightlineset width

f7c56fa

Correct the test for empty boxsets

1c65df5

Poperly handle point/line scales and ssaa, creator needs to know both.

c1f18ef

Missing stuff from prev commit. Add bottom light.

d252d95

Make specular reflection in RcFancyMaterial almoust white

1de30db

Improve check for empty calo 2d and calo 3d to remove lint warnings

04d9833

Optimize visibility changes

db8a0ce

GlViewverRCore: point light construction with shadow-map size = 0.

5a148b6

Update RenderCore.tar.gz

0626fae

Add missing shader.

86f72b2

Pass x,y to mouse-move handler timeout, not event -- the event gets m…

ecab6c9

…odified in Firefox.

Correction in outline colors and selection/highligt sorting

8f27322

Make RenderCore the default render engine.

3c5b622

Correct warning on implied digitset collection

28f56ad

Check for extra selection data in implied selected elements

a5798bf

[RCore] Fix reading of depth value in Firefox.

108a32d

osschar requested a review from linev as a code owner December 20, 2022 07:14

osschar mentioned this pull request Dec 20, 2022

[REve] Update to RenderCore release from github, deploy it as builtin tarball root-project/root#11936

Merged

[eve7] fix compiler warning with REvePointSet

a53eff3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[REve] Update to RenderCore release from github, deploy it as builtin tarball. #41

[REve] Update to RenderCore release from github, deploy it as builtin tarball. #41

Uh oh!

osschar commented Dec 20, 2022 •

edited

Loading

Uh oh!

Uh oh!

[REve] Update to RenderCore release from github, deploy it as builtin tarball. #41

Are you sure you want to change the base?

[REve] Update to RenderCore release from github, deploy it as builtin tarball. #41

Uh oh!

Conversation

osschar commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

osschar commented Dec 20, 2022 •

edited

Loading