build: Add and publish npm package lockfile#145
build: Add and publish npm package lockfile#145jackylamhk wants to merge 3 commits intooss-serverless:mainfrom
Conversation
|
Please don't use |
Probably the wrong forum to discuss this, but locking the entire dependency tree is the goal of this PR to introduce build reproducibility. I understand that it is horrible for library consumers, but this package is used as a standalone CLI tool anyway. |
|
CLI tools like this should still be added as a dependency for applications, just like with Using a lockfile gives build reproducibility, which is something that everyone should be doing. Also worth pointing out that shrink wrapping is only respected by (also ultimately what you've described sounds like a bug in the package manager itself, or the registry 🤷) |
|
If we commit
Keep in mind (as it's said above) that it's not distributed as a CLI but via NPM. |
package-lock.jsonto ensure every child dependency is pinned across local and CI.npm-shrinkwrap.jsonto ensure the published package will install pinned child dependencies.Seeing a recurring weird issue where an unpublished
@aws-sdk/coreversion is requested during the short window AWS publishes new SDK versions.