Skip to content

Conversation

@daniel-kr
Copy link
Contributor

@daniel-kr daniel-kr commented Oct 8, 2025

As soon as any package curation is applied to a package, the original operator of its license expression is changed to always AND which semantically changes the expression if the operator was OR before. This fix reconstructs the original operator.

Fixes #10721.

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.53%. Comparing base (2e1640b) to head (2d42333).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10961   +/-   ##
=========================================
  Coverage     57.53%   57.53%           
+ Complexity     1705     1703    -2     
=========================================
  Files           346      346           
  Lines         12833    12833           
  Branches       1212     1212           
=========================================
  Hits           7383     7383           
  Misses         4985     4985           
  Partials        465      465           
Flag Coverage Δ
funTest-docker 71.03% <ø> (ø)
funTest-non-docker 32.70% <ø> (-0.12%) ⬇️
test-ubuntu-24.04 42.33% <ø> (ø)
test-windows-2025 42.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sschuberth
Copy link
Member

Thanks @daniel-kr! I wanted to quickly do some adjustments, but seem like you didn't enable "Maintainers are allowed to edit this pull request". Can you do that, or is it not permitted by your organization?

@daniel-kr
Copy link
Contributor Author

Thanks @daniel-kr! I wanted to quickly do some adjustments, but seem like you didn't enable "Maintainers are allowed to edit this pull request". Can you do that, or is it not permitted by your organization?

I don't see the option. I guess it is disabled somehow. I try to get it enabled in my organization. Does "edit" refer to the PR metadata or do you want to push to the feature branch?

@sschuberth
Copy link
Member

Does "edit" refer to the PR metadata or do you want to push to the feature branch?

See this. So it's about (force) pushing to that feature branch only; it does not give access to the whole fork.

@daniel-kr daniel-kr force-pushed the preserve-original-license-operator-upon-package-curation branch from 7778507 to 8f7e170 Compare October 9, 2025 07:41
@daniel-kr
Copy link
Contributor Author

@sschuberth I think I addressed all of your remarks. Please re-review.

@sschuberth
Copy link
Member

Fixes #10721

One last nit: Please put this in the body of the commit message (with a trailing period), not (only) in the PR discussion.

@daniel-kr daniel-kr force-pushed the preserve-original-license-operator-upon-package-curation branch from 8f7e170 to 2d42333 Compare October 9, 2025 08:03
@daniel-kr
Copy link
Contributor Author

One last nit: Please put this in the body of the commit message (with a trailing period), not (only) in the PR discussion.

Done. Tell me if there is anything else to be done.

@sschuberth sschuberth merged commit f01d859 into oss-review-toolkit:main Oct 9, 2025
26 checks passed
@sschuberth
Copy link
Member

Tell me if there is anything else to be done.

All good, thanks a lot for the contribution!

@daniel-kr daniel-kr deleted the preserve-original-license-operator-upon-package-curation branch October 9, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"OR" in License is falsely concluded as "AND" with package Maven:net.java.dev.jna:jna:5.8.0

2 participants