-
Notifications
You must be signed in to change notification settings - Fork 366
fix: Preserve original license operator when applying package curations #10961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Preserve original license operator when applying package curations #10961
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10961 +/- ##
=========================================
Coverage 57.53% 57.53%
+ Complexity 1705 1703 -2
=========================================
Files 346 346
Lines 12833 12833
Branches 1212 1212
=========================================
Hits 7383 7383
Misses 4985 4985
Partials 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @daniel-kr! I wanted to quickly do some adjustments, but seem like you didn't enable "Maintainers are allowed to edit this pull request". Can you do that, or is it not permitted by your organization? |
I don't see the option. I guess it is disabled somehow. I try to get it enabled in my organization. Does "edit" refer to the PR metadata or do you want to push to the feature branch? |
See this. So it's about (force) pushing to that feature branch only; it does not give access to the whole fork. |
7778507 to
8f7e170
Compare
|
@sschuberth I think I addressed all of your remarks. Please re-review. |
One last nit: Please put this in the body of the commit message (with a trailing period), not (only) in the PR discussion. |
Fixes oss-review-toolkit#10721. Signed-off-by: Daniel Kreck <daniel.kreck@cplace.com>
8f7e170 to
2d42333
Compare
Done. Tell me if there is anything else to be done. |
All good, thanks a lot for the contribution! |
As soon as any package curation is applied to a package, the original operator of its license expression is changed to always
ANDwhich semantically changes the expression if the operator wasORbefore. This fix reconstructs the original operator.Fixes #10721.