Skip to content

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Apr 17, 2025

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth requested review from oheger-bosch and a team as code owners April 17, 2025 13:59
@sschuberth sschuberth changed the title chore(plugsin): Do not repeat the type as part of the display name chore(plugins): Do not repeat the type as part of the display name Apr 17, 2025
@sschuberth sschuberth force-pushed the plugin-display-names branch from 5e50048 to f0f1ecb Compare April 17, 2025 13:59
@sschuberth sschuberth enabled auto-merge (rebase) April 17, 2025 14:00
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.43%. Comparing base (13b50b3) to head (80aba1d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10190   +/-   ##
=========================================
  Coverage     56.43%   56.43%           
+ Complexity     1606     1604    -2     
=========================================
  Files           331      331           
  Lines         12243    12243           
  Branches       1135     1135           
=========================================
  Hits           6909     6909           
  Misses         4887     4887           
  Partials        447      447           
Flag Coverage Δ
funTest-non-docker 33.42% <ø> (-0.14%) ⬇️
test-ubuntu-24.04 40.45% <ø> (ø)
test-windows-2022 40.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sschuberth sschuberth force-pushed the plugin-display-names branch 2 times, most recently from 2f92694 to 747d22c Compare April 18, 2025 06:47
factory = OrtCommandFactory::class
)
class AdvisorCommand(descriptor: PluginDescriptor = AdvisorCommandFactory.descriptor) : OrtCommand(descriptor) {
class AdviseCommand(descriptor: PluginDescriptor = AdviseCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "AdviseCommand" is never used
factory = OrtCommandFactory::class
)
class AnalyzerCommand(descriptor: PluginDescriptor = AnalyzerCommandFactory.descriptor) : OrtCommand(descriptor) {
class AnalyzeCommand(descriptor: PluginDescriptor = AnalyzeCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "AnalyzeCommand" is never used
factory = OrtCommandFactory::class
)
class DownloaderCommand(descriptor: PluginDescriptor = DownloaderCommandFactory.descriptor) : OrtCommand(descriptor) {
class DownloadCommand(descriptor: PluginDescriptor = DownloadCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "DownloadCommand" is never used
factory = OrtCommandFactory::class
)
class NotifierCommand(descriptor: PluginDescriptor = NotifierCommandFactory.descriptor) : OrtCommand(descriptor) {
class NotifyCommand(descriptor: PluginDescriptor = NotifyCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "NotifyCommand" is never used
factory = OrtCommandFactory::class
)
class ReporterCommand(descriptor: PluginDescriptor = ReporterCommandFactory.descriptor) : OrtCommand(descriptor) {
class ReportCommand(descriptor: PluginDescriptor = ReportCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "ReportCommand" is never used
factory = OrtCommandFactory::class
)
class ScannerCommand(descriptor: PluginDescriptor = ScannerCommandFactory.descriptor) : OrtCommand(descriptor) {
class ScanCommand(descriptor: PluginDescriptor = ScanCommandFactory.descriptor) : OrtCommand(descriptor) {

Check warning

Code scanning / QDJVMC

Unused symbol

Class "ScanCommand" is never used
@sschuberth sschuberth changed the title chore(plugins): Do not repeat the type as part of the display name Plugin id / display name refactorings Apr 23, 2025
@sschuberth sschuberth marked this pull request as draft April 23, 2025 19:03
auto-merge was automatically disabled April 23, 2025 19:03

Pull request was converted to draft

@sschuberth

This comment was marked as outdated.

This aligns plugin display names on shorter names. While at it, slightly
improve some display names, e.g. by spelling out "Dir" as "Directory".

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Capitalize them and make longer names more readable.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth force-pushed the plugin-display-names branch from 747d22c to 80aba1d Compare May 12, 2025 12:35
@sschuberth sschuberth changed the title Plugin id / display name refactorings Plugin display name chores May 12, 2025
@sschuberth sschuberth marked this pull request as ready for review May 12, 2025 12:35
@sschuberth sschuberth requested a review from mnonnenmacher May 12, 2025 12:35
@sschuberth sschuberth enabled auto-merge (rebase) May 12, 2025 12:36
@sschuberth sschuberth disabled auto-merge May 12, 2025 18:23
@sschuberth
Copy link
Member Author

Merging early as all relevant checks have passed.

@sschuberth sschuberth merged commit 0f156a5 into main May 12, 2025
23 of 25 checks passed
@sschuberth sschuberth deleted the plugin-display-names branch May 12, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants