implemented i18n #89
implemented i18n #89
Conversation
|
@kruemelro this is so awesome, great work! i don't have much time this week, i'll review and merge it next week for sure. Thanks again! |
| @@ -17,6 +17,7 @@ echo "Git SHA: $GIT_SHA" | |||
|
|
|||
| docker build -f "$SCRIPT_DIR/Dockerfile" \ | |||
| --progress=plain \ | |||
| -t "registry.pthome.de/splitpro:latest" \ | |||
There was a problem hiding this comment.
Good finding :-) I pushed it to my local registry for testing and missed to exclude the changed build script in the PR
| import { initReactI18next } from 'react-i18next'; | ||
|
|
||
| export const supportedLngs = { | ||
| en: "English", |
There was a problem hiding this comment.
Maybe you also need to add de ?
|
Really cool feature ! It would be great if the translations were also available on the homepage. If I have some time, I'll add a language selector to the menu. |
|
I'll add Polish/Russian/Ukrainian translations after merge |
|
this is will be added to 2.0. i'll keep this PR open |
I have implemented the language selector in my branch that is based on this PR. https://github.com/alexanderwassbjer/split-pro/tree/feature/i18n-support |
|
Good PR! Some missing strings otherwise good! @KMKoushik I can continue on this PR and add all the missing strings, fix language switcher, date-fns locale support etc. Do you want me to continue and make a PR? 😊 |
|
Any news here? Switching language would be great! |
I've implemented i18n translation framework and also added English and German as language. I'm no developer, so please have a look over it