Fix ListPath for ADJ_IN and EnableFiltered=true and add tests.
#2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, even though `ApplyPolicy` is called for determining the accepted routes after apply policy, the new route with attribute modifications is not returned. This is problematic for gRPC API users. Tests are added for all four cases that were described in osrg#2765. This PR makes the behaviour correct for "Case/Attempt 2" described in the issue.
|
I thought about a new parameter to avoid breaking the API but I guess that we call this issue a bug so pushed. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even though
ApplyPolicyis called for determining the accepted routes after apply policy, the new route with attribute modifications is not returned. This is problematic for gRPC API users.Validation is added within
TestListPathEnableFilteredfor all four cases that were described in #2765. This PR makes the behaviour conform to "Case/Attempt 2" described in the issue.