Add convenient error handling macros#30
Merged
ivanpauno merged 10 commits intogalactic-develfrom Sep 8, 2020
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This was referenced Sep 3, 2020
jacobperron
reviewed
Sep 8, 2020
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
A couple doc bugs and nitpicks; looks reasonable to me.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…s://github.com/osrf/ros2_java into ivanpauno/add-convenient-error-handling-macros
jacobperron
approved these changes
Sep 8, 2020
|
LGTM, once cpplint failure is fixed. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Collaborator
Author
|
Going in, thanks for the review @jacobperron ! |
Collaborator
Author
|
I should have |
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
Add macros to handle java exceptions Add macros to throw a java exception from an rcl error Always use `base_message` instead of `message` in docblocks Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
Add macros to handle java exceptions Add macros to throw a java exception from an rcl error Always use `base_message` instead of `message` in docblocks Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have extracted this from #25, as I'm planning to use this in an unrelated PR.