Add offered qos incompatible event and event executor test#11
Conversation
rcljava/src/main/java/org/ros2/rcljava/events/publisher_statuses/OfferedQosIncompatible.java
Show resolved
Hide resolved
😂 |
jacobperron
left a comment
There was a problem hiding this comment.
Besides the minor comments above, this LGTM
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
9951769 to
d7ad984
Compare
|
I have rebased |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
@jacobperron there are some event statuses that we want but are not available in foxy (e.g. message lost), should we create a (edit) that should be done after completing basic event handling support in the foxy branch |
|
Unrelated, but I want to get rid of all stale branches. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Yeah, feel free to create a
Go ahead and delete stale branches 👍 |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
(edit) #10 has already been merged.
This PR is build on top of #10.
It adds a new publisher event status:
OfferedQosIncompatible.That new event status is used to test the executor code in #10, which surprisingly works without changes.
There are some other cosmetic changes here.
I will rebase and redirect the PR to
feature/eventswhen #10 gets merged.