Skip to content

Add config argument parsing capability #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agyoungs
Copy link
Contributor

@agyoungs agyoungs commented Mar 27, 2025

Use the ConfigArgParse library to support passing in rocker configurations with a config (toml, ini, yaml, etc) file.

Currently the ConfigArgParse library needs some updates, so I've put this work on hold, but as those updates are made and I make progress on this branch I figured I'd create a placeholder here.

ConfigArgParse limitations preventing forward progress on this PR:

  • Inability to handle -- separation at the end of a list argument
  • Out of date with latest python version
  • A few bugs with multi line variables

TODO:

  • unit tests
  • handling several config file formats

@agyoungs agyoungs mentioned this pull request Mar 27, 2025
@tfoote
Copy link
Collaborator

tfoote commented Apr 3, 2025

Thanks for the update and draft here for future visibilty. This looks like a great way to make it happen, but those limitations you flagged are pretty much blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants