[Tidy] Fix syscall deprecation on macOS #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syscall to get thread id is deprecated on macOS as of 10.12. This replaces the syscall with a std:: library call. I found this code mod in a another project here gabime/spdlog@b715378#diff-075620b19501eee6536187116b2c8ff9R183 and discussion of it here gabime/spdlog#74.
facebook-github-bot
added
the
cla signed
theopolis
reviewed
May 29, 2017
osquery/core/posix/process_ops.cpp
Outdated
| #if !defined(FREEBSD) | ||
| #if defined(__APPLE__) | ||
| return std::hash<std::thread::id>()(std::this_thread::get_id()); | ||
| #elif !defined(FREEBSD) |
There was a problem hiding this comment.
Would std::this_thread::get_id work on FreeBSD too?
|
@jedi22 updated the pull request - view changes |
|
test freebsd please |
|
Fbsd build will break until this gets resolved: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syscall to get thread id is deprecated on macOS as of 10.12. This replaces the syscall with a std:: library call. I found this code mod in another project here and discussion of it here.