Warn user if updating wrong settings after setup #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some settings can't be updated after calling `setup`, now users will be warned if they try to do so after `setup`
|
|
|
Thanks for doing this and sorry it hasn't been looked at until now. There is actually already a check in the Matlab class wrapper here https://github.com/oxfordcontrol/osqp-matlab/blob/master/osqp.m#L569 that is supposed to stop the setting of these settings after the initial setup. It would be better if the other settings that don't work after initialization are added to that check instead of in the mex file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some settings can't be updated after calling
setup, now users will be warned if they try to do so aftersetup