-
Notifications
You must be signed in to change notification settings - Fork 356
Wrote tests for AlbumServiceImpl #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zachary-berdell-elliott
wants to merge
14
commits into
osopromadze:main
Choose a base branch
from
zachary-berdell-elliott:feature/add-junit-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wrote tests for AlbumServiceImpl #60
zachary-berdell-elliott
wants to merge
14
commits into
osopromadze:main
from
zachary-berdell-elliott:feature/add-junit-tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @zachary-berdell-elliott for creating your first PR, the Spring-Boot-Blog-REST-API community thanks you :)
…using users to be unable to delete a user in scenarios where they should be able to.
akshay117
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started to work on implementing unit tests as part of Request for Test Addition #57
Still writing unit tests for other places that can use them.
Fixes # 57
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I ran the unit tests on my local after writing them and they passed. I also used the debugger tool in Intellij to step through the code and make sure the right things were being tested by adding breakpoints before the method calls.
Checklist: