Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for checking list of ip addresses #181

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

kengu
Copy link
Contributor

@kengu kengu commented Feb 10, 2024

See #180

@kengu kengu marked this pull request as ready for review February 10, 2024 18:13
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.53%. Comparing base (5737f1d) to head (b43f2e9).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../src/services/impls/host_scanner_service_impl.dart 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #181      +/-   ##
==========================================
+ Coverage   75.22%   75.53%   +0.30%     
==========================================
  Files          23       23              
  Lines         553      564      +11     
==========================================
+ Hits          416      426      +10     
- Misses        137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-elliot
Copy link
Collaborator

Hi @kengu, new architecture is merged recently. Can you adjust your code according to new services based implementation. #183

@kengu
Copy link
Contributor Author

kengu commented Feb 24, 2024

Hi @kengu, new architecture is merged recently. Can you adjust your code according to new services based implementation. #183

Fixed!

@git-elliot git-elliot merged commit 4a348ac into osociety:dev Mar 14, 2024
5 checks passed
@kengu kengu deleted the issue/180 branch March 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants