fix #9356

[gap-editor]

Remove mempool-1559 as a configuration option, fixes #9356

At this point, all nodes should be running the 1559 mempool implementation, so we no longer need to maintain the configuration option. This PR removes the adaptive-fee-enabled configuration parameter and makes the 1559 mempool behavior the default for all nodes.

Changes made:

1. Removed Mempool1559Enabled field from MempoolFeeOptions structure in x/txfees/types/options.go
2. Removed GlobalMempool1559Enabled variable and parseMempool1559() function
3. Removed Mempool1559Enabled field from OsmosisMempoolConfig structure in cmd/osmosisd/cmd/root.go
4. Removed the adaptive-fee-enabled configuration option from the app template
5. Updated feedecorator.go to always use the 1559 mempool logic without conditional checks
6. Added an entry to CHANGELOG.md regarding this change

This change simplifies the codebase by removing unnecessary conditional logic and ensures all nodes have a consistent fee market behavior.

[coderabbitai]

Walkthrough

This pull request removes the mempool 1559 configuration option from the codebase. The changes eliminate the Mempool1559Enabled field in configuration structures and its associated default value and parsing logic. Conditional checks based on this field in fee calculation methods have also been removed, resulting in unconditioned execution of the relevant fee logic. Overall, the adaptive fee toggle for mempool 1559 has been fully deprecated from both the node configuration and fee option modules.

Changes

Files	Change Summary
cmd/osmosisd/cmd/root.go	Removed Mempool1559Enabled field, its default value, and corresponding configuration template line.
x/txfees/keeper/feedecorator.go	Removed conditional checks and the is1559enabled variable, simplifying fee calculation by omitting the mempool 1559 based conditional logic.
x/txfees/types/options.go	Removed variables (GlobalMempool1559Enabled, DefaultMempool1559Enabled), the Mempool1559Enabled field in MempoolFeeOptions, and the associated parseMempool1559 function.
CHANGELOG.md	Added entry documenting the removal of the mempool 1559 option, indicating it is now always enabled.

Sequence Diagram(s)

sequenceDiagram
    participant Node as Node
    participant FD as FeeDecorator
    participant BFC as BaseFeeCalculator

    Node->>FD: Submit Transaction
    FD->>BFC: Request Current Base Fee
    BFC-->>FD: Return Base Fee
    FD->>Node: Process Transaction with Retrieved Fee

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Remove mempool 1559 as a configuration option (#9356)	✅

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92ead37 and b52eb75.

📒 Files selected for processing (1)

• CHANGELOG.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• CHANGELOG.md

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ValarDragon]

Looks good to me, just needs a changelog entry saying "removed config option to enable eip1559. Its now always on"

[gap-editor]

@ValarDragon ✅