Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves ValidatePermissionlessPoolCreationEnabled out of poolmanager module #6421

Merged
merged 13 commits into from
Sep 24, 2023
Merged

Moves ValidatePermissionlessPoolCreationEnabled out of poolmanager module #6421

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
17c7339
in progress
sunnya97 Sep 16, 2023
c249317
fix params setting
sunnya97 Sep 17, 2023
c59a191
add param to newParams function
sunnya97 Sep 17, 2023
2f4701e
refactored where validate permissionless is checked
sunnya97 Sep 17, 2023
3fb7fa0
add tests
sunnya97 Sep 17, 2023
0ff556f
remove todos
sunnya97 Sep 17, 2023
3d35de5
lint
sunnya97 Sep 17, 2023
1a18bf6
Apply suggestions from code review
sunnya97 Sep 17, 2023
9382028
fix tests
sunnya97 Sep 17, 2023
20cc46c
Update x/concentrated-liquidity/keeper.go
sunnya97 Sep 22, 2023
1f93e24
Merge branch 'main' into sunny/move-permissionless-check-into-pool
sunnya97 Sep 24, 2023
98c32c3
Apply suggestions from code review
sunnya97 Sep 24, 2023
fa10809
Update CHANGELOG.md
sunnya97 Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@sunnya97
sunnya97 committed Sep 17, 2023
commit 3d35de563fcf0b9b56348280044fe5881f3fd868
5 changes: 1 addition & 4 deletions x/concentrated-liquidity/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,7 @@ func (k *Keeper) SetListeners(listeners types.ConcentratedLiquidityListeners) *K
// ValidatePermissionlessPoolCreationEnabled returns nil if permissionless pool creation in the module is enabled.
// Otherwise, returns an error.
func (k Keeper) ValidatePermissionlessPoolCreationEnabled(ctx sdk.Context) bool {
if !k.GetParams(ctx).IsPermissionlessPoolCreationEnabled {
return false
}
return true
return !k.GetParams(ctx).IsPermissionlessPoolCreationEnabled
}

// GetAuthorizedQuoteDenoms gets the authorized quote denoms from the poolmanager keeper.
Expand Down