Gamm code improvements #3657
Merged
Gamm code improvements #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/gamm
dalmirel
added
the
V:state/compatible/backport
ValarDragon
reviewed
Dec 8, 2022
| @@ -360,7 +360,7 @@ func (k Keeper) JoinSwapShareAmountOut( | |||
| } | |||
|
|
|||
| if tokenInAmount.GT(tokenInMaxAmount) { | |||
| return sdk.Int{}, sdkerrors.Wrapf(types.ErrLimitMaxAmount, "%d resulted tokens is larger than the max amount of %d", tokenInAmount.Int64(), tokenInMaxAmount.Int64()) | |||
| return sdk.Int{}, sdkerrors.Wrapf(types.ErrLimitMaxAmount, "%s resulted tokens is larger than the max amount of %s", tokenInAmount, tokenInMaxAmount) | |||
ValarDragon
approved these changes
Dec 8, 2022
p0mvn
approved these changes
Dec 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Added target and init weights length check on CLI * gamm utils conv helpers moved to osmoutils * gamm CLI typo fix * gamm num of pool assets defined constants * sdk.Int to Int64 cast removed from err wrapping (cherry picked from commit c659f20)
p0mvn
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Added target and init weights length check on CLI * gamm utils conv helpers moved to osmoutils * gamm CLI typo fix * gamm num of pool assets defined constants * sdk.Int to Int64 cast removed from err wrapping (cherry picked from commit c659f20) Co-authored-by: Mirel Dalčeković <97894739+dalmirel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is created during the Informal Systems audit, after analysis of the existing specification and code inspection
Auditing is performed on commit hash: 42d73f1
This PR contains minor GAMM module code improvements noticed during code inspection with the aim of finding issues.
Brief Changelog
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework/code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no