De-duplicate sim module setup #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
mattverse
reviewed
Jun 16, 2022
| ), | ||
| app.TransferModule, | ||
| // recreate list of modules, to ensure no issues with overriding prior module structs. | ||
| modules := appModules(app, encodingConfig, skipGenesisInvariants) |
There was a problem hiding this comment.
Seems like the modules returned from appModules is different from the existing modules that were hard coded? Is this change intended / is there context that I missed here?
There was a problem hiding this comment.
The prior ones that weren't here were just forgotten tbh, because this was too much of a pain to maintain
alexanderbez
approved these changes
Jun 16, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The simulation module setup code is an unnecessary large duplication of logic. This PR makes it get most of the simulation modules from run-time type casting, and allowing overrides where necessary.
This should ideally be upstreamed to the SDK, and then be a really simple helper method we call.
Brief Changelog
Testing and Verifying
This change is a minor rework. Also not that impactful, as we don't really use the simulator within osmosis.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no