Implement IBC channel handshake #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ethanfrey
commented
Jun 20, 2023
•
ethanfrey
commented
- Add version handshake logic
- Extends documentation on channel handshake protocol
- Add all ibc entry points as stubs for external-staking and converter
- Implement the 3 channel lifetime calls
- Add E2E tests (with Go ibctesting?)
|
This is implemented and documented. We need E2E tests, but I think that is not blocking the merge |
maurolacy
approved these changes
Jun 21, 2023
| @@ -70,6 +70,20 @@ The general process (assuming a vault is already established on the provider) is | |||
| 3. Create IBC channel from provider to consumer | |||
| 4. Apply to consumer governance to provide a virtual staking max cap to the associated virtual staking contract, so that this connection may have voting power. | |||
|
|
|||
| ### Handshake | |||
| @@ -73,6 +74,10 @@ impl ExternalStakingContract<'_> { | |||
|
|
|||
| set_contract_version(ctx.deps.storage, CONTRACT_NAME, CONTRACT_VERSION)?; | |||
|
|
|||
| // Question: do we need to validate here? Is there a defined schema for such | |||
| // Question: should we add a query endpoint for this? | |||
There was a problem hiding this comment.
I think so. Just turn into a TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.