-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize producer apis #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Having owner_by_proxy
query is a good add.
cbf4a7d
to
3b07623
Compare
Lien - A claim on some collateral (from local- or cross-staking contract). Collateral with existing | ||
liens may not be withdrawn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do Liens represent both:
- how much could be under slashing risk
- duration it must be locked for?
Or is the duration it must be locked for each 'lien' tracked separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duration is tracked by the LocalStaking / CrossStaking contract.
The vault doesn't care if it is bonded or unbonding. Only when it is finally released do we remove the lien.
(It is only the first point)
For each user, the total amount of potential slashing over all liens is less than or | ||
equal to their total collateral (important if doing many cross-stakes, or with high slashing rates): | ||
`liens(user).map(|x| x.lien * x.max_slashing_rate).sum() <= collateral(user)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a todo for ourselves, to reason about how to express chain's restrictions on when you could go above max slashing rate. (Issue being that correlated slashing can make the max slashing rate quite high)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make an issue for this.
I don't fully understand the question - or what "correlated slashing" is
Closes #2