Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce VirtualStakingMock #149

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Introduce VirtualStakingMock #149

merged 6 commits into from
Oct 19, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 16, 2023

Part of #95

@uint
Copy link
Contributor Author

uint commented Oct 17, 2023

I'm giving up on removing the virtual_staking_mock from converter. I can't really find a sensible way to do it without custom module support from Sylvia. I instead suggest merging the module mock for use in the future.

@uint uint changed the title Remove contract mocks ~~Remove contract mocks~~ Introduce VirtualStakingMock Oct 17, 2023
@uint uint changed the title ~~Remove contract mocks~~ Introduce VirtualStakingMock Introduce VirtualStakingMock Oct 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b11d54c) 86.17% compared to head (ae5ac0e) 86.17%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files          70       70           
  Lines       10447    10447           
  Branches    10447    10447           
=======================================
  Hits         9003     9003           
  Misses       1004     1004           
  Partials      440      440

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uint uint marked this pull request as ready for review October 17, 2023 15:13
@uint uint requested a review from maurolacy October 17, 2023 15:13
maurolacy
maurolacy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maurolacy maurolacy merged commit 69b8401 into main Oct 19, 2023
4 checks passed
@maurolacy maurolacy deleted the 95-remove-contract-mocks branch October 19, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uint @codecov-commenter @maurolacy