Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default gas to 350,000 #47

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

mattverse
Copy link
Member

Description

Closes: osmosis-labs/osmosis#675

Bumping default gas set by cli command to 350,000 to avoid unnecessary confusion in using cli.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ValarDragon
Copy link
Member

Needs to be PR'd against what we set as the default branch!

@mattverse
Copy link
Member Author

Just noticed after seeing hundreds of files being needed to be reviewed

@mattverse mattverse changed the base branch from master to v0.44.3x-osmo-v5 December 22, 2021 19:19
@sunnya97 sunnya97 changed the title Change default gas to 350,000 fix: change default gas to 350,000 Dec 26, 2021
@ValarDragon ValarDragon merged commit a83eecc into v0.44.3x-osmo-v5 Jan 1, 2022
sunnya97 pushed a commit that referenced this pull request Jan 24, 2022
@alexanderbez alexanderbez deleted the mattverse/change-default-gas branch March 30, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment