Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gRPC query for operator and chain configuration #426

Merged
merged 4 commits into from
Mar 24, 2023
Merged

feat: gRPC query for operator and chain configuration #426

merged 4 commits into from
Mar 24, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 23, 2023 •
edited
Loading

@github-actions github-actions bot added the C:CLI label Mar 23, 2023
@p0mvn p0mvn changed the title Roman/config-query feat: gRPC query for operator and chain configuration Mar 23, 2023
@p0mvn p0mvn marked this pull request as ready for review March 23, 2023 04:33
@p0mvn p0mvn requested a review from a team March 23, 2023 04:33
mattverse
mattverse approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/start.go
Comment on lines +293 to +295
if a, ok := app.(types.ApplicationQueryService); ok {
a.RegisterNodeService(clientCtx)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats a possible condition that app might not be implementing ApplicationQueryService?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it has something related to the versionings of sdk 0.46, and trying not to break it, but don't have a clear idea in my mind

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's correct. It's to avoid having SDK 0.46 app breaking our app API

@p0mvn p0mvn merged commit 490febe into osmosis-main Mar 24, 2023
@p0mvn p0mvn deleted the roman/config-query branch March 24, 2023 15:50
@mergify mergify bot mentioned this pull request Mar 24, 2023
Merged
p0mvn added a commit that referenced this pull request Mar 24, 2023
@p0mvn
feat: gRPC query for operator and chain configuration (backport #426)
de417a2
p0mvn added a commit that referenced this pull request Mar 25, 2023
@mergify @p0mvn
feat: gRPC query for operator and chain configuration (backport #426) (…
8ee894c 
…#427)

Co-authored-by: Roman <roman@osmosis.team>
p0mvn added a commit that referenced this pull request Mar 25, 2023
@mergify @p0mvn
feat: gRPC query for operator and chain configuration (backport #426) (…
c600e98 
…#427)

Co-authored-by: Roman <roman@osmosis.team>
@mergify mergify bot mentioned this pull request Mar 25, 2023
Merged
p0mvn added a commit that referenced this pull request Mar 25, 2023
@p0mvn
feat: gRPC query for operator and chain configuration (backport #426)
2b3dcbe
p0mvn added a commit that referenced this pull request Mar 25, 2023
@mergify @p0mvn
feat: gRPC query for operator and chain configuration (backport #426) (…
43c58d9 
…#429)

* feat: gRPC query for operator and chain configuration (backport #426)

* try rosetta fix

---------

Co-authored-by: Roman <roman@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic

@nicolaslara nicolaslara Awaiting requested review from nicolaslara

Assignees
No one assigned
Labels
C:CLI
Projects
Osmosis Chain Development
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @mattverse @alexanderbez