crypto/merkle: optimize merkle tree hashing (#6513) (#9446) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* crypto/merkle: optimize merkle tree hashing (#6513) Upstream celestiaorg/celestia-core#351 to optimize merkle tree hashing ``` benchmark old ns/op new ns/op delta BenchmarkHashAlternatives/recursive-8 22914 21949 -4.21% BenchmarkHashAlternatives/iterative-8 21634 21939 +1.41% benchmark old allocs new allocs delta BenchmarkHashAlternatives/recursive-8 398 200 -49.75% BenchmarkHashAlternatives/iterative-8 399 301 -24.56% benchmark old bytes new bytes delta BenchmarkHashAlternatives/recursive-8 19088 6496 -65.97% BenchmarkHashAlternatives/iterative-8 21776 13984 -35.78% ``` cc @odeke-em @cuonglm * update pending log Co-authored-by: Marko <marbar3778@yahoo.com>
czarcas7ic
commented
Apr 23, 2024
crypto/merkle/proof.go
Outdated
Comment on lines
53
to
55
| if rootHash == nil { | ||
| return fmt.Errorf("invalid root hash: cannot be nil") | ||
| } |
There was a problem hiding this comment.
Want to verify this is okay, this was not from the PR but was a part of the diff between this and the branch the original feat was merged to.
3 tasks
czarcas7ic
added a commit
that referenced
this pull request
Apr 24, 2024
…25) (#26) * crypto/merkle: optimize merkle tree hashing (#6513) (#9446) * crypto/merkle: optimize merkle tree hashing (#6513) Upstream celestiaorg/celestia-core#351 to optimize merkle tree hashing ``` benchmark old ns/op new ns/op delta BenchmarkHashAlternatives/recursive-8 22914 21949 -4.21% BenchmarkHashAlternatives/iterative-8 21634 21939 +1.41% benchmark old allocs new allocs delta BenchmarkHashAlternatives/recursive-8 398 200 -49.75% BenchmarkHashAlternatives/iterative-8 399 301 -24.56% benchmark old bytes new bytes delta BenchmarkHashAlternatives/recursive-8 19088 6496 -65.97% BenchmarkHashAlternatives/iterative-8 21776 13984 -35.78% ``` cc @odeke-em @cuonglm * update pending log Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 8e787f0) * add changelog (cherry picked from commit 9e015e0) * add back rootHash nil check (cherry picked from commit 4b602f8) * update changelog (cherry picked from commit 6b1d05f) --------- Co-authored-by: JayT106 <JayT106@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream celestiaorg/celestia-core#351 to optimize merkle tree hashing
cc @odeke-em @cuonglm
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments