Bump speed limit on living street for specific countries

[mattanelkaim]

Issue #1008 started it all, stating that “No maxspeed limit above 20km/h is known”, according to the living_street wiki page. Since 2020 (issue opened), this page was updated and new maxspeeds were added for more national specialities. Also, the maxspeed wiki page has country-specific values for living streets, which aren't on the living_street page.

Since this check was added, editors from multiple areas of the world are facing false positives.

From the living_street wiki page:

• Austria - 20 or 30
• Denmark - at most 30
• Ireland - either 50 or 30
• Israel - 30
• Japan - usually 30 or 20

From the maxspeed wiki page:

• Uzbekistan - 30

Currently 3 of these are definite (Denmark, Israel, Uzbekistan), thus we should at least start with bumping the rule from 20 to 30 maxspeed in these regions.

[mattanelkaim]

Also - anyone knows how to reach JOSM validation to correct there as well? @Klumbumbus added the original (general) one to JOSM, but I'm not sure they're active nowadays..

[Klumbumbus]

I changed the rule in JOSM from >20 to >30 for Austria, Denmark, Israel, Uzbekistan.
For Ireland and Japan the wiki page states to use highway=residential (instead of highway=living_street).

https://josm.openstreetmap.de/changeset/19433/josm

[mattanelkaim]

Thank you! I'll close this issue once the JOSM change takes effect in Osmose :)

[Famlam]

It seems like updating will be a bit more difficult than expected:
in Osmose, the two assertMatch don't match anymore. This is possibly because it's false for 4 countries and the test doesn't specify which country we're running the test in.

I can think of two solutions:

• We'll have to make a local copy of this rule with context-aware asserts
• We update the tests to match the inside/outside selectors (taking care of cases like [inside("CA")][outside("CA-CQ")]). This however will be difficult in cases like this rule where one selector contains an inside and the other an outside- how to decide which one to apply. It seems JOSMs behavior is a bit complex as well, so I'm not sure if we'd match its behavior in this case:

/* JOSM happily accepts both the inside and outside here */
node[x][inside("GR")] {
  throwWarning: "test";
  assertMatch: "node x=1";
}
node[x][outside("GR")] {
  throwWarning: "test";
  assertMatch: "node x=2";
}

/* But it disallows the second assert here */
node[x][!z][inside("IN")],
node[y][!z][inside("GR")] {
  throwWarning: tr("missing tag {0}", "{1.key}");
  assertMatch: "node x=1";
  assertMatch: "node y=1";
} 

[mattanelkaim]

The second solution seems like a clever one indeed.
I might've misunderstood the issue with it, but to my knowledge there aren't (or at least none documented on OSM Wiki) any sub-regions within countries where the maxspeed for a living_street would differ from the country's. Meaning Quebec shouldn't differ from Canada in this case.

Also, pinging @Klumbumbus since Chile was added to the Wiki page as well, stating "30 (unless otherwise stated)"🙂.

[Klumbumbus]

Added Chile in JOSM:
https://josm.openstreetmap.de/changeset/19440/josm