Skip to content

XTerm auto fit add-on not auto-adjusting to parent container #32

@crumblepie

Description

@crumblepie

Context (current result)

Currently the size of the xterm terminal is hardcoded in TerminalView.jsx. This means the terminal is not resizing to the parent container (the active tab content container).

Expected result

XTerm resizes when the user resizes the main window.

Process to reproduce

  1. Comment out the maxWidth and maxHeight properties for the main BrowserWindow on around lines 59 and 60 of main.jsx.
  2. npm run start and switch to the Terminal tab
  3. Try resizing the main window and the terminal will stay constant size

Screenshots

Screen Shot 2022-02-18 at 10 48 19 am

Possible Fix

Some suggestions of possible places to start:

  • Terminal.css file
  • Issues in Xterm's issues list relating to xterm-addon-fit

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions