-
-
Notifications
You must be signed in to change notification settings - Fork 8
Steve/object type #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t type to datatypes.ts and dango.ts, some minor change to dango_test and schema
…a to be assigned to schemaMap, started on validateAgainstSchema - in middle of checkDataFields
…lateQuery - now can insert nested schemas multiple levels deep and return to parent levels to assign more data, assigned objects i.e. this.schema.schemaMap, this.updatedQueryObject to variables; steve_test.ts: more tests written
…idateInsertAgainstScheme code
…tedQueryObject and schema are now required, also adjusted arguments for invokations for validateInsertAgainstSchema at insertOne and insertMany method of query.ts
…passing early manual testing, needs more testing
…, schema, connections and other changes
…values in embedded objects, updated validateInsertAgainstSchema; updated validateReplaceAgainstSchema - still need to update checkUniqueForReplace to allow embedded object checking
…added comments to validate functions and related functions. steve_test.ts with additional tests.
wgreco13
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steve, excellent job on the subschema validation. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated query.ts: edited validateInsertAgainstSchema and 2 other validate functions, and their related functions.
Added steve_test.ts for testing validation
updated schema.ts for SchemaObject class
updated dango.ts for this.types, object: SchemaObject