Skip to content

Steve/object type #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 17, 2022
Merged

Steve/object type #31

merged 13 commits into from
May 17, 2022

Conversation

sjue32
Copy link
Collaborator

@sjue32 sjue32 commented May 17, 2022

updated query.ts: edited validateInsertAgainstSchema and 2 other validate functions, and their related functions.

Added steve_test.ts for testing validation
updated schema.ts for SchemaObject class
updated dango.ts for this.types, object: SchemaObject

Stephen Jue added 13 commits May 10, 2022 01:05
…t type to datatypes.ts and dango.ts, some minor change to dango_test and schema
…a to be assigned to schemaMap, started on validateAgainstSchema - in middle of checkDataFields
…lateQuery - now can insert nested schemas multiple levels deep and return to parent levels to assign more data, assigned objects i.e. this.schema.schemaMap, this.updatedQueryObject to variables; steve_test.ts: more tests written
…tedQueryObject and schema are now required, also adjusted arguments for invokations for validateInsertAgainstSchema at insertOne and insertMany method of query.ts
…passing early manual testing, needs more testing
…values in embedded objects, updated validateInsertAgainstSchema; updated validateReplaceAgainstSchema - still need to update checkUniqueForReplace to allow embedded object checking
…added comments to validate functions and related functions. steve_test.ts with additional tests.
Copy link
Collaborator

@wgreco13 wgreco13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve, excellent job on the subschema validation. Approved!

@wgreco13 wgreco13 merged commit f560f70 into dev May 17, 2022
@sjue32 sjue32 deleted the steve/object-type branch May 18, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants