Skip to content

Conversation

@jdvplus
Copy link
Contributor

@jdvplus jdvplus commented Nov 7, 2025

hey y'all,

really really great work here so far. very impressed with how much code you've already contributed and committed to the project.

left some of my thoughts in the form of comments and edits – feel free to follow what feels useful and valuable.

my biggest pieces of advice right now:

  • remove commented out code where possible; pointless to keep dead code as you can always refer to past commits to find old work (this will also motivate you to write better commits!)
  • keep naming consistent; establish conventions and follow them

these two pieces alone will help the codebase feel more polished and organized. remember that with open-source work, your work is public and seen by other developers – so you'll want to make sure it's as readable and clean as possible for everyone's benefit.

@jdvplus jdvplus self-assigned this Nov 7, 2025
@eodafoo
Copy link
Collaborator

eodafoo commented Nov 11, 2025

Thank you Jaime

Copy link
Collaborator

@eodafoo eodafoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@eodafoo eodafoo merged commit 8660a3b into main Nov 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants