Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More database table renaming #619

Merged
merged 11 commits into from
Aug 27, 2020
Merged

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Aug 27, 2020

To normalize naming and make it more obvious which tables are related.

These are all user/role related so renaming for consistency:

  • oskari_jaas_users -> oskari_users_credentials
  • oskari_role_oskari_user -> oskari_users_roles
  • oskari_role_external_mapping -> oskari_roles_external_mapping since these are related to oskari_roles table

These are all related to statistical data and renamed for consistency:

  • oskari_user_indicator -> oskari_statistical_indicator
  • oskari_user_indicator_data -> oskari_statistical_indicator_data
  • oskari_statistical_layer -> oskari_statistical_datasource_regionsets

Added a prefix so oskari related database tables are easier to recognize:

  • ratings -> oskari_ratings

Same as with statistical/user tables the link between resource and permissions is now more clear with the naming change:

  • oskari_permission -> oskari_resource_permission to indicate permissions are always linked to resources. Note! Also renamed oskari_resource_id column to resource_id

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ZakarFin ZakarFin added this to the 2.0 milestone Aug 27, 2020
@ZakarFin ZakarFin marked this pull request as ready for review August 27, 2020 14:02
@ZakarFin ZakarFin merged commit d541351 into oskariorg:develop Aug 27, 2020
@ZakarFin ZakarFin deleted the table-names branch August 27, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant