Split metadata strings on first colon only #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatandsheep
requested changes
Aug 4, 2020
goatandsheep
approved these changes
Aug 4, 2020
|
@osk Please let me know if there is anything you'd like me to focus on to get this into master. |
|
@goatandsheep & @jaimefps thanks both. I've released v1.9.1 @jaimefps, I'm currently not working in the video space so I'm not up-to-date on everything. If there are any features/fixes according to spec/things to make live easier, I'm all ears! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37
Code change to handle metadata fields that contain multiple colons.
For example:
X-TIMESTAMP-MAP=LOCAL:00:00:00.000,MPEGTS:0See WebVtt specs:
https://tools.ietf.org/html/rfc8216#section-3.5
Thanks for this awesome module.
This PR only prevents the code from breaking when multiple colons are present in the metadata string.
It does not include actual full support for
X-TIMESTAMP-MAPAlso seeing some work around this metadata in this code:
https://github.com/osk/node-webvtt/blob/master/lib/hls.js#L17
But that line does not match the specs for
X-TIMESTAMP-MAP.Please let me know if you rather I focus on that part of the code, instead of my current PR.