Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hours timestamp should support more than 2 digits #117

Closed
slifty opened this issue May 12, 2022 · 2 comments · Fixed by #118
Closed

Hours timestamp should support more than 2 digits #117

slifty opened this issue May 12, 2022 · 2 comments · Fixed by #118

Comments

@slifty
Copy link
Contributor

slifty commented May 12, 2022 •
edited
Loading

The WebVTT spec says that the timesttamps should be:

A WebVTT timestamp consists of the following components, in the given order:
Optionally (required if hours is non-zero):
Two or more ASCII digits, representing the hours as a base ten integer.

Right now any hours longer than 2 digits are truncated to only include the final two digits of the hours count.
slifty added a commit to slifty/node-webvtt that referenced this issue May 12, 2022
@slifty
Support longer times
4c60714 
The WebVTT spec says that the hours section of a timestamp must be "at
least 2 digits" but the parser was only accepting the first two digits
(and dropping the rest).  This meant that "100:00:00" was being
interpreted as "00:00:00"

Hours can now be as long as we want

Issue osk#117 Hours timestamp should support more than 2 digits
@slifty slifty mentioned this issue May 12, 2022
Merged
@slifty
Copy link
Contributor Author

slifty commented May 17, 2022

Thank you @goatandsheep for merging!

@osk do you know if you will be planning to release an updated build with this change?

@osk
Copy link
Owner

osk commented May 17, 2022 •
edited
Loading

@slifty v1.9.4 released now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support longer times slifty/node-webvtt
2 participants
@osk @slifty