Added ability to sepcifiy different values for ldap 'host' and 'name' #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… useful for k8s which will often have different internal and external names
BertrandGouny
added a commit
that referenced
this pull request
Sep 4, 2018
Member
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use case for this is Kubernetes where the external and internal names will be different.
Within Kubernetes you address services by .. the service name will often include elements related to the deployment.
Eg Externally you might want to use
ldap.example.orgas the friendly name to display to the end user. Within the kubernetes cluster this may beopenldap-master.internal.k8s.example.orgwhereopenldap-masteris the service name,internalis the namespace andk8s.example.orgis the cluster name