Fix Python 2.7 CentOS issue by requiring argparse only in Py2.6#19
Open
avengerpenguin wants to merge 6 commits intoosiegmar:masterfrom
Open
Fix Python 2.7 CentOS issue by requiring argparse only in Py2.6#19avengerpenguin wants to merge 6 commits intoosiegmar:masterfrom
avengerpenguin wants to merge 6 commits intoosiegmar:masterfrom
Conversation
Implemented Load Average metric collection.
Update from upstream
Fix Python 2.7 CentOS issue by requiring argparse only in Py2.6
lalkhum
reviewed
Apr 12, 2018
setup.py
Outdated
| requires = ['boto>=2.33.0',] | ||
|
|
||
|
|
||
| if sys.version_info == (2, 6): |
There was a problem hiding this comment.
Line 18 should rather be sys.version_info[:2] == (2,6).
lalkhum
approved these changes
May 9, 2018
osiegmar
requested changes
Dec 19, 2020
| requires = ['boto>=2.33.0',] | ||
|
|
||
|
|
||
| if sys.version_info[:2] == (2, 6): |
Owner
There was a problem hiding this comment.
Sorry for my late response, I weren't notified via email for this PR.
I doubt this is enough as this is probably also required for Python < 2.7 and < 3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my comments in #9