Python 3 support #13
Closed
Python 3 support #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like you can't support version < 3.3 without explicitly addressing unicode string types. See http://python-modernize.readthedocs.io/en/latest/#a-note-about-handling-text-literals. I'll just remove it for now.
osiegmar
requested changes
Jan 28, 2017
| self.values.append(value) | ||
| self.dimensions.append(dict(common_dims.items() + dim.items())) | ||
| final_dims = common_dims.copy() | ||
| final_dims.update(dims) |
Owner
There was a problem hiding this comment.
This results in a runtime error:
ERROR: dictionary update sequence element #0 has length 1; 2 is required
| dims = {'InstanceId': instance_id} | ||
| if xdims: | ||
| dims = dict(dims.items() + xdims.items()) | ||
| dims.update(xdims) |
Owner
There was a problem hiding this comment.
Not sure, if this may result in the same problem as below...
Owner
|
Thanks for your work! Please check the review comments. |
Owner
|
Thanks for your valuable input! Python 3 support was added due to your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some minimal smoke testing of this by calling the metrics classes directly. It's a pretty straight forward port. But some real tests would make me feel a lot better.