Support arguments where possible for Logback and Slf4j #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Generally LGTM. Is it possible to add a unit test for your use case? |
|
Something like this? d57c871 |
|
Noticed that the previous commit failed on formatting (spotless checks). Fixed that now. |
|
Added some changes. I am still not 100% sure about this change as arguments are not used by all implementations. Anyway I added a comment that the api might change in the future. |
|
Thanks! will be released in 7.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #457
Added arguments array and passed it to underlying loggers where possible, not all loggers seem to support it. (Array instead of the initially proposed Set, because that is the datatype used by the underlying loggers.)