allow only markers being supplied #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
renovate bot
referenced
this pull request
in StefanLobbenmeier/yt-dlp-compose
Apr 6, 2024
…33) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.3` -> `6.0.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v6.0.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.4) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.3...6.0.4) #### What's Changed - Bump actions/cache from 3.3.3 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/395](https://togithub.com/oshai/kotlin-logging/pull/395) - Fluent Logging: Allow nullable values by [@​Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks) in [https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402) - Bump multiplatform from 1.9.22 to 1.9.23 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/405](https://togithub.com/oshai/kotlin-logging/pull/405) - Bump org.jetbrains.dokka from 1.9.10 to 1.9.20 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/406](https://togithub.com/oshai/kotlin-logging/pull/406) - Bump actions/cache from 4.0.0 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/403](https://togithub.com/oshai/kotlin-logging/pull/403) - Bump com.diffplug.spotless from 6.24.0 to 6.25.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/397](https://togithub.com/oshai/kotlin-logging/pull/397) - allow only markers being supplied by [@​ewoelfel](https://togithub.com/ewoelfel) in [https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408) - Upgrade ktfmt to version 0.47 by [@​mlewe](https://togithub.com/mlewe) in [https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415) - Allow supplying org.slf4j.Marker by [@​mlewe](https://togithub.com/mlewe) in [https://github.com/oshai/kotlin-logging/pull/414](https://togithub.com/oshai/kotlin-logging/pull/414) #### New Contributors - [@​Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402) - [@​ewoelfel](https://togithub.com/ewoelfel) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408) - [@​mlewe](https://togithub.com/mlewe) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415) **Full Changelog**: oshai/kotlin-logging@6.0.3...6.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
nikclayton
referenced
this pull request
in pachli/pachli-android
Apr 10, 2024
….0.4 (#605) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.3` -> `6.0.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v6.0.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.4) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.3...6.0.4) #### What's Changed - Bump actions/cache from 3.3.3 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/395](https://togithub.com/oshai/kotlin-logging/pull/395) - Fluent Logging: Allow nullable values by [@​Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks) in [https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402) - Bump multiplatform from 1.9.22 to 1.9.23 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/405](https://togithub.com/oshai/kotlin-logging/pull/405) - Bump org.jetbrains.dokka from 1.9.10 to 1.9.20 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/406](https://togithub.com/oshai/kotlin-logging/pull/406) - Bump actions/cache from 4.0.0 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/403](https://togithub.com/oshai/kotlin-logging/pull/403) - Bump com.diffplug.spotless from 6.24.0 to 6.25.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/397](https://togithub.com/oshai/kotlin-logging/pull/397) - allow only markers being supplied by [@​ewoelfel](https://togithub.com/ewoelfel) in [https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408) - Upgrade ktfmt to version 0.47 by [@​mlewe](https://togithub.com/mlewe) in [https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415) - Allow supplying org.slf4j.Marker by [@​mlewe](https://togithub.com/mlewe) in [https://github.com/oshai/kotlin-logging/pull/414](https://togithub.com/oshai/kotlin-logging/pull/414) #### New Contributors - [@​Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402) - [@​ewoelfel](https://togithub.com/ewoelfel) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408) - [@​mlewe](https://togithub.com/mlewe) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415) **Full Changelog**: oshai/kotlin-logging@6.0.3...6.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the api could be improved a bit by not requiring the throwable, which could result in the following:
Especially you do not need to supply a throwable when logging info in this case.
Due to the deprecation of the previous methods the test still uses deprecated methods.
If the old methods are removed, the problem wont occur anymore.