Skip to content

Conversation

@WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1794 (a tweak for that)

Feature

Describe features of this pull request

And when the highlighted index is bigger than the compact candidates child count, the unrolled candidates window will be attached automatically.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

And when the highlighted index is bigger than the compact candidates child count, the unrolled candidates window will be attached automatically.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables highlighting effects for unrolled candidates by propagating the highlighted index from compact candidates to the unrolled candidate window. When a highlighted candidate index exceeds the compact view's capacity, the unrolled candidates window is automatically attached with the appropriate item highlighted.

  • Adds automatic window attachment when highlighted index exceeds compact candidate count
  • Propagates highlight state through the adapter chain to properly style highlighted items
  • Introduces new state machine state AboutToAttachWindow for automatic window transitions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
BaseUnrolledCandidateWindow.kt Passes highlightedIndex from compact adapter to unrolled adapter when refreshing
PagingCandidateViewAdapter.kt Adds highlightedIndex property and applies highlighting based on calculated index
CompactCandidateModule.kt Pushes UnrolledCandidatesHighlighted state when highlighted index exceeds child count
CandidateItemUi.kt Renames parameter from isHighlighted to highlighted for consistency
UnrollButtonStateMachine.kt Adds AboutToAttachWindow state and UnrolledCandidatesHighlighted boolean key for automatic window attachment
QuickBar.kt Handles new AboutToAttachWindow state to automatically open unrolled window

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bambooin Bambooin merged commit 041675a into osfans:develop Jan 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.37版本,候选项高亮问题

2 participants